Sanitizers target modificators #138736
Open
Sanitizers target modificators #138736
+311
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
7526d38 to
0777169
Compare
This comment has been minimized.
This comment has been minimized.
99 tasks
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
0777169 to
f454b02
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
f454b02 to
509e0b3
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
509e0b3 to
1f20a51
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
1f20a51 to
fc95e77
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
2 times, most recently
from
e025a55 to
c54dcfc
Compare
|
☔ The latest upstream changes (presumably #138974) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? compiler |
26 tasks
|
Do we have any tests that check simultaneous use of multiple sanitizers? For example, if I enable both shadow-call-stack and kcfi at the same time, then both must also be enabled in deps. |
|
@rustbot claim |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #142443) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@azhogin Any chance you could look at this again? |
Sure, I will. |
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
f04eb8c to
455b1c6
Compare
|
Some changes occurred in tests/codegen-llvm/sanitizer cc @rcvalle |
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
455b1c6 to
2106c51
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
2106c51 to
5551d8c
Compare
|
@bors try |
rust-bors bot
added a commit
that referenced
this pull request
Aug 12, 2025
…s, r=<try> Sanitizers target modificators
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 13, 2025
…modificators, r=rcvalle Sanitizers target modificators Depends on bool flag fix: rust-lang#138483. Some sanitizers need to be target modifiers, and some do not. For now, we should mark all sanitizers as target modifiers except for these: AddressSanitizer, LeakSanitizer For kCFI, the helper flag -Zsanitizer-cfi-normalize-integers should also be a target modifier. Many test errors was with sanizer flags inconsistent with std deps. Tests are fixed with `-C unsafe-allow-abi-mismatch`.
jdonszelmann
added a commit
to jdonszelmann/rust
that referenced
this pull request
Aug 13, 2025
…modificators, r=rcvalle Sanitizers target modificators Depends on bool flag fix: rust-lang#138483. Some sanitizers need to be target modifiers, and some do not. For now, we should mark all sanitizers as target modifiers except for these: AddressSanitizer, LeakSanitizer For kCFI, the helper flag -Zsanitizer-cfi-normalize-integers should also be a target modifier. Many test errors was with sanizer flags inconsistent with std deps. Tests are fixed with `-C unsafe-allow-abi-mismatch`.
bors
added a commit
that referenced
this pull request
Aug 13, 2025
Rollup of 9 pull requests Successful merges: - #122661 (Change the desugaring of `assert!` for better error output) - #138736 (Sanitizers target modificators) - #144955 (search graph: lazily update parent goals) - #145120 (llvm: Accept new LLVM lifetime format) - #145153 (Handle macros with multiple kinds, and improve errors) - #145189 (Weekly `cargo update`) - #145250 (Add regression test for former ICE involving malformed meta items containing interpolated tokens) - #145309 (Fix `-Zregparm` for LLVM builtins) - #145331 (Make std use the edition 2024 prelude) r? `@ghost` `@rustbot` modify labels: rollup
fmease
reviewed
Aug 13, 2025
tests/ui/sanitizer/address.rs
Outdated
There was a problem hiding this comment.
@azhogin I know it's been difficult to merge this. Sorry about that. Would you mind taking a look at it again whenever you have time?
There was a problem hiding this comment.
I am looking at this atm, just don't understand the problem with tests/ui/sanitizer/address.rs.
Did I understand it correctly, that with new changes, the test doesn't generate expected sanitizer error? Or it just generates at different line?
There was a problem hiding this comment.
The error is generated at a different line, i.e., line 15.
There was a problem hiding this comment.
Thanks, I have updated tests to minimize line offsets changes that may cause problems in different architectures.
bors
added
S-waiting-on-author
…t modifiers with custom consistency check function
azhogin
force-pushed
the
azhogin/sanitizers-target-modificators
branch
from
5551d8c to
bf38919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bool flag fix: #138483.
Some sanitizers need to be target modifiers, and some do not. For now, we should mark all sanitizers as target modifiers except for these: AddressSanitizer, LeakSanitizer
For kCFI, the helper flag -Zsanitizer-cfi-normalize-integers should also be a target modifier.
Many test errors was with sanizer flags inconsistent with std deps. Tests are fixed with
-C unsafe-allow-abi-mismatch.